Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for copilot seats api #21

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

@alexpalvanov alexpalvanov requested review from tomer-amir, GalApiiro and a team December 27, 2023 10:02
@tomer-amir
Copy link

tomer-amir commented Dec 27, 2023

Look good in general, but please note that the build failed (here)

It says something about a missing constructor params:

Error Message:
   Octokit.Tests.Conventions.MissingPublicConstructorWithAllPropertiesException : Model type 'Octokit.Copilot.CopilotSeatsResponse' is missing a constructor with all properties. Closest match is missing the following properties: 

Did you test this with LIM?

@alexpalvanov
Copy link
Author

@tomer-amir I fix this UT, but other probably fail, for example, AllModelsHaveDebuggerDisplayAttribute , which didn't pass even before my change, and it is really not important.

I tested this code with UTs I created in the client, working against our github service (didn't commit of course)
So, Lim will work with this new client package after it will be merged ...

@alexpalvanov alexpalvanov merged commit b5331d4 into main Dec 27, 2023
2 of 4 checks passed
@alexpalvanov alexpalvanov deleted the alexp/add-support-for-copilot-seats-api branch December 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants